Add CI workflow to check c10 is synced with PyTorch #10403
Conversation
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10403
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This script checks that all files in our c10 copy are in sync with our pinned version of PyTorch. Test Plan: 1) detected us being out of sync when I wrote this PR 2) CI to run it and make sure that we are clean now ghstack-source-id: 90ff96c ghstack-comment-id: 2825037146 Pull-Request-resolved: #10403
facebook-github-bot
added
the
CLA Signed
swolchok
requested review from
GregoryComer,
jathu,
kimishpatel,
larryliu0820 and
mergennachin
mergennachin
left a comment
mergennachin
left a comment
There was a problem hiding this comment.
Yeah, this looks like a good policy
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
where is this file being used?
There was a problem hiding this comment.
whoops! supposed to be the thing that the workflow calls
| exit 1 | ||
| fi | ||
|
|
||
| while IFS= read -r -d '' file; do |
There was a problem hiding this comment.
Thoughts on continuing after errors (instead of exiting on first mismatch)
This script checks that all files in our c10 copy are in sync with our pinned version of PyTorch. Test Plan: 1) detected us being out of sync when I wrote this PR 2) CI to run it and make sure that we are clean now ghstack-source-id: f19bb5c ghstack-comment-id: 2825037146 Pull-Request-resolved: #10403
|
ugh, I don't recall clicking the merge button on this PR. will re-send (all it did was merge into previous PR) |
accidentally sent this out with the order of the stack reversed and I guess that's how github chose to reflect what I did. replacement is #10413 |
This script checks that all files in our c10 copy are in sync with our pinned version of PyTorch. Test Plan: 1) detected us being out of sync when I wrote this PR 2) CI to run it and make sure that we are clean now ghstack-source-id: ca04bfa ghstack-comment-id: 2825037146 Pull-Request-resolved: pytorch/executorch#10403
This script checks that all files in our c10 copy are in sync with our pinned version of PyTorch.
NOTE TO REVIEWERS: as part reviewing this PR, please weigh in on whether this is a sensible policy. Instinctively, I wanted to allow temporary divergence from the pinned PyTorch version, but I'm unable to articulate why. It now seems like this is the only sensible policy, as our c10 copy is logically part of our PyTorch pin.
Test Plan: 1) detected us being out of sync when I wrote this PR
2) CI to run it and make sure that we are clean now